Thank you!
]]> http://benjamin.wittorf.me/code/wordpress/plugins/htmltidy-for-wordpress/comment-page-1/#comment-15 Rahim Sonawalla Wed, 06 Jan 2010 20:14:33 +0000 http://benjamin.wittorf.me/?page_id=31#comment-15 Thanks for the fantastic plugin, it's exactly what I needed. Just FYI, I was having a problem with Wordpress 2.9 and htmltidy where I was unable to log in to the admin panel (the page would be blank). For others running into the same problem, the fix is to add an extra exclusion: [Line 61 in htmltidy-for-wordpress.php] <code class="php">stripos($_SERVER['REQUEST_URI'], 'wp-login.php') === false &&</code> Thanks for the fantastic plugin, it’s exactly what I needed. Just FYI, I was having a problem with Wordpress 2.9 and htmltidy where I was unable to log in to the admin panel (the page would be blank). For others running into the same problem, the fix is to add an extra exclusion:[Line 61 in htmltidy-for-wordpress.php] stripos($_SERVER['REQUEST_URI'], 'wp-login.php') === false &&
I’ll answer your last question first: === is a comparison operator that states if $a is equal to $b, and they are of the same type
. So as long as there is no output buffer, it’s not only empty, it doesn’t exist and thus it’s false. (That type of comparison might be characteristic to PHP.) I could also write it just like you suggested, though.
Now, about the output buffer itself – for various compatibility reasons I needed to make sure the output buffer hadn’t been modified at another point until where it should be “HTML tidied” (e.g. some caching plugins were playing afoul; WP Super Cache and Hyper Cache play nice). I might re-check that and comment it out if testing goes well (credit’s to you, then).
Also, please note that I’m currently working on a new version that isn’t depended on HTML Tidy anymore which hopefully allows me to get rid of more of these kind of “hacks”.
]]> http://benjamin.wittorf.me/code/wordpress/plugins/htmltidy-for-wordpress/comment-page-1/#comment-13 Moltar Wed, 06 Jan 2010 20:12:25 +0000 http://benjamin.wittorf.me/?page_id=31#comment-13 I'm having a problem with <code class="php">ob_get_length() === false</code> part. If I comment it out, the plugin works. It seems like the condition isn't satisfied there. Docs mention that the return value is <i>int</i>, but you compare to <i>false</i>, which is bool, so it would never be satisfied. I am not pro with PHP, so maybe I am wrong. I come from Perl background, where I'd just say <code>!ob_get_length() && …</code> I’m having a problem withob_get_length() === false part. If I comment it out, the plugin works. It seems like the condition isn’t satisfied there. Docs mention that the return value is int, but you compare to false, which is bool, so it would never be satisfied. I am not pro with PHP, so maybe I am wrong. I come from Perl background, where I’d just say !ob_get_length() && …
]]>
http://benjamin.wittorf.me/code/wordpress/plugins/htmltidy-for-wordpress/comment-page-1/#comment-12 Benjamin Wittorf Wed, 06 Jan 2010 20:10:28 +0000 http://benjamin.wittorf.me/?page_id=31#comment-12 Hey Jonathan, thank you and thanks for your comment. I'm not exactly sure what you mean, though: Do you mean to have actual empty lines before articles and comments? If so, I'm afraid no (but this is something I'll put on my to-do list, thank you). For an example how the source code looks like after it's been processed just have a look at the source code of this page.
Hey Jonathan, thank you and thanks for your comment. I’m not exactly sure what you mean, though: Do you mean to have actual empty lines before articles and comments? If so, I’m afraid no (but this is something I’ll put on my to-do list, thank you). For an example how the source code looks like after it’s been processed just have a look at the source code of this page.
]]>
http://benjamin.wittorf.me/code/wordpress/plugins/htmltidy-for-wordpress/comment-page-1/#comment-11 Jonathan Wed, 06 Jan 2010 20:09:57 +0000 http://benjamin.wittorf.me/?page_id=31#comment-11 Great plugin, Benjamin. Does it also add whitespace before lines in articles and comments? That's been a pet-peeve, and something I haven't been able to alleviate.
Great plugin, Benjamin. Does it also add whitespace before lines in articles and comments? That’s been a pet-peeve, and something I haven’t been able to alleviate.
]]>
http://benjamin.wittorf.me/code/wordpress/plugins/htmltidy-for-wordpress/comment-page-1/#comment-10 Benjamin Wittorf Wed, 06 Jan 2010 20:08:49 +0000 http://benjamin.wittorf.me/?page_id=31#comment-10 RockyMtnHi – you'll need to download the plugin this entry is about (see section <a href="#tidy_download" rel="nofollow">Download htmltidy for WordPress</a>) and install it according to the included installation instructions (unzip, upload to the WordPress plugins directory, activate in the plugins settings of your WordPress admininistration pages). Please don't confuse this plugin to be php-tidy. You need it installed to use this plugin with WordPress.
RockyMtnHi – you’ll need to download the plugin this entry is about (see section Download htmltidy for WordPress) and install it according to the included installation instructions (unzip, upload to the WordPress plugins directory, activate in the plugins settings of your WordPress admininistration pages).
Please don’t confuse this plugin to be php-tidy. You need it installed to use this plugin with WordPress.
]]> http://benjamin.wittorf.me/code/wordpress/plugins/htmltidy-for-wordpress/comment-page-1/#comment-9 RockyMtnHi Wed, 06 Jan 2010 20:07:44 +0000 http://benjamin.wittorf.me/?page_id=31#comment-9 I have gone through a lot of pages and documention for php-tidy but I can’t see how to install it in Wordpress 2.6.1. Can you assist here? Many thanks. I have gone through a lot of pages and documention for php-tidy but I can’t see how to install it in Wordpress 2.6.1.
but I guess I can be lucky to have a “remove-a-single-semicolon” installation on my closed source OS I love it. Thanks for the tip!
]]>
http://benjamin.wittorf.me/code/wordpress/plugins/htmltidy-for-wordpress/comment-page-1/#comment-7 Benjamin Wittorf Wed, 06 Jan 2010 20:05:25 +0000 http://benjamin.wittorf.me/?page_id=31#comment-7 Erik – thanks for your comment. Of course, this plugin is not only about indenting (but, it is, too, I must admit). Glad you still like the idea, though! Yes, I indeed installed it manually, but not in an environment similar to yours. The good old <code>apt-get install php5-tidy</code> did it for me (that’s Linux). On Windows, if you have installed PHP5, you’ll just need to active it in the php.ini. If you’re using PHP4 you’ll need to get the php_tidy.dll from somewhere and do funny things with it. Let me know if you need some further assistance.
Erik – thanks for your comment. Of course, this plugin is not only about indenting (but, it is, too, I must admit). Glad you still like the idea, though!
Yes, I indeed installed it manually, but not in an environment similar to yours. The good old apt-get install php5-tidy did it for me (that’s Linux). On Windows, if you have installed PHP5, you’ll just need to active it in the php.ini. If you’re using PHP4 you’ll need to get the php_tidy.dll from somewhere and do funny things with it. Let me know if you need some further assistance.